Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance router #4

Merged
merged 5 commits into from
Dec 31, 2023
Merged

Enhance router #4

merged 5 commits into from
Dec 31, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Dec 28, 2023 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

New feature: method <-> action mapping

class IndexController
{
    public static array $actions = [
        'GET' => 'index',
        'DELETE' => 'delete', // action not found, the router will be skipped, a next middleware will be called
    ];
    public function index(): ResponseInterface
    {
        // ...
    }
}

@xepozz xepozz changed the title Remove deps Enhance router Dec 28, 2023
@xepozz xepozz added the status:code review The pull request needs review. label Dec 29, 2023
@xepozz xepozz merged commit e1882a5 into master Dec 31, 2023
14 checks passed
@xepozz xepozz deleted the remove-deps branch December 31, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xepozz @samdark